[improve][docs] Add schema compatibility between Go and Java client #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BewareMyPower @shibd |
shibd
reviewed
Jul 31, 2023
| ], | ||
| "name":"MyAvro","namespace":"schemaNotFoundTestCase","type":"record"}`, nil) | ||
| // Not compatible with defining a schema in Java |
There was a problem hiding this comment.
Does this refer to the following Java example?
If the Go Client is used like this, the Java client should also support it, right?
In java client, there are two ways:
- Use SchemaDefinition to set schema JsonDef
String jsonDef = "{"fields":[{"name":"id","type":"int"},{"default":null,"name":"name","type":["null","string"]}],"name":"MyAvro","namespace":"schemaNotFoundTestCase","type":"record"}"
Schema schema = Schema.AVRO(SchemaDefinition.builder().withJsonDef("").build());
- Or, to set not allow field is null.
SchemaDefinition<Example> schemaDefinition =
SchemaDefinition.builder().withPojo(Example.class).withAlwaysAllowNull(false).build();
Schema schema = Schema.AVRO(schemaDefinition);
Producer<Example> producer = pulsarClient.newProducer(schema)
.topic(topic).create();
we should show the solution.
There was a problem hiding this comment.
Oh, you are right.
|
|
||
| consumerJSCompatible := NewJSONSchema(exampleSchemaDefCompatible, nil) | ||
| // Not compatible with defining a schema in Java |
There was a problem hiding this comment.
Which define code of Java is this incompatible with?
There was a problem hiding this comment.
Like Avro, is a problem with null fields.
tisonkun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original PR: apache/pulsar-client-go#1056
docdoc-requireddoc-not-neededdoc-complete